Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : Override liveness and readiness probes in MLServer #2622

Closed

Conversation

adriangonz
Copy link
Contributor

@adriangonz adriangonz commented Nov 10, 2020

What this PR does / why we need it:

Override readiness and liveness probes to remove flaky 404 error during integration tests.

Which issue(s) this PR fixes:

Fixes #2589

Special notes for your reviewer:

This PR will be a WIP until we can confirm that the 404 doesn't appear any more.

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign adriangonz
You can assign the PR to them by writing /assign @adriangonz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Nov 10 14:19:39 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2622/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2622 --build=2

@seldondev
Copy link
Collaborator

Tue Nov 10 14:19:44 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2622/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2622 --build=1

@seldondev
Copy link
Collaborator

Tue Nov 10 14:21:09 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2622/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2622 --build=3

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Nov 10 16:05:32 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2622/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2622 --build=4

@seldondev
Copy link
Collaborator

@adriangonz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 6588093 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@adriangonz
Copy link
Contributor Author

The last run of integration tests raised the 404 error again, so this doesn't fix the issue.

_________________________ TestPrepack.test_sklearn_v2 __________________________
[gw1] linux -- Python 3.6.10 /usr/local/bin/python

self = <test_prepackaged_servers.TestPrepack object at 0x7f511e8bceb8>
namespace = 'test-sklearn-v2'

    @skipif_engine
    def test_sklearn_v2(self, namespace):
        deploy_model(
            "sklearn",
            namespace=namespace,
            protocol="kfserving",
            model_implementation="SKLEARN_SERVER",
            model_uri="gs://seldon-models/sklearn/iris",
        )
        wait_for_status("sklearn", namespace)
        wait_for_rollout("sklearn", namespace)
        time.sleep(1)
    
        logging.warning("Initial request")
        r = v2_protocol.inference_request(
            model_name="sklearn",
            namespace=namespace,
            payload={
                "inputs": [
                    {
                        "name": "input-0",
                        "shape": [1, 4],
                        "datatype": "FP32",
                        "data": [[0.1, 0.2, 0.3, 0.4]],
                    }
                ],
            },
        )
>       assert r.status_code == 200
E       assert 404 == 200
E         -404
E         +200

@adriangonz adriangonz closed this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix notebook failing integartion tests for sklearn and xgboost V2
2 participants