New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP : Override liveness and readiness probes in MLServer #2622
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test integration |
Tue Nov 10 14:19:39 UTC 2020 impatient try |
Tue Nov 10 14:19:44 UTC 2020 impatient try |
Tue Nov 10 14:21:09 UTC 2020 impatient try |
/test integration |
Tue Nov 10 16:05:32 UTC 2020 impatient try |
@adriangonz: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
The last run of integration tests raised the 404 error again, so this doesn't fix the issue.
|
What this PR does / why we need it:
Override readiness and liveness probes to remove flaky 404 error during integration tests.
Which issue(s) this PR fixes:
Fixes #2589
Special notes for your reviewer:
This PR will be a WIP until we can confirm that the 404 doesn't appear any more.
Does this PR introduce a user-facing change?: