Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: add feedback to batch processor #2653

Merged
merged 4 commits into from
Nov 18, 2020
Merged

WIP: add feedback to batch processor #2653

merged 4 commits into from
Nov 18, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Nov 16, 2020 •
edited
Loading

What this PR does / why we need it:

Extends batch-processor to be able to send feedback messages.
Feedback messages must be provided in the "raw" format.

Works both with gRPC and REST.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@RafalSkolasinski RafalSkolasinski marked this pull request as draft November 16, 2020 18:30
@seldondev
Copy link
Collaborator

Mon Nov 16 18:32:18 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2653/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2653 --build=2

@seldondev
Copy link
Collaborator

Mon Nov 16 18:32:26 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2653/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2653 --build=1

@seldondev
Copy link
Collaborator

Wed Nov 18 15:17:05 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2653/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2653 --build=4

@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review November 18, 2020 15:17
@seldondev
Copy link
Collaborator

Wed Nov 18 15:17:26 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2653/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2653 --build=3

@seldondev
Copy link
Collaborator

Wed Nov 18 15:22:29 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2653/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2653 --build=5

@seldondev
Copy link
Collaborator

Wed Nov 18 15:22:29 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2653/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2653 --build=6

axsaucedo
axsaucedo reviewed Nov 18, 2020
View reviewed changes
Copy link
Contributor

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added a couple of minor comments, other than that looks good to go

python/seldon_core/batch_processor.py Outdated
}
}
# Feedback Protos does not support meta and SeldonClient.feedback does not support headers
# feedback_kwargs["meta"] = meta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove (or if moved to single function can be left under if statement)

python/seldon_core/batch_processor.py Outdated
str_output = None
for i in range(retries):
try:
# TODO: Add functionality for explainer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move todos into issues where possiuble

axsaucedo
axsaucedo reviewed Nov 18, 2020
View reviewed changes
python/seldon_core/batch_processor.py Outdated
str_output = json.dumps(seldon_payload.response)
break
except (requests.exceptions.RequestException, AssertionError) as e:
# print("Exception:", e, "retries:", retries)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REmove

@seldondev
Copy link
Collaborator

Wed Nov 18 15:39:13 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2653/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2653 --build=7

@seldondev
Copy link
Collaborator

Wed Nov 18 15:39:18 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2653/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2653 --build=8

@seldondev
Copy link
Collaborator

Wed Nov 18 15:42:40 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2653/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2653 --build=10

@seldondev
Copy link
Collaborator

Wed Nov 18 15:42:41 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2653/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2653 --build=9

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

Wed Nov 18 15:50:22 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2653/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2653 --build=12

@seldondev
Copy link
Collaborator

Wed Nov 18 15:50:28 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2653/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2653 --build=11

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 6d79282 into SeldonIO:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo axsaucedo left review comments

Assignees
No one assigned
Labels
approved do-not-merge/work-in-progress size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RafalSkolasinski @seldondev @axsaucedo