Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tensorflow prediction from explainer #2671

Merged
merged 3 commits into from
Nov 20, 2020
Merged

Fix tensorflow prediction from explainer #2671

merged 3 commits into from
Nov 20, 2020

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

  • Fixes the calling of a tensorflow model via seldon for the explainer wrapper

Which issue(s) this PR fixes:

Fixes #2664

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

Thu Nov 19 14:45:54 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2671/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2671 --build=1

@seldondev
Copy link
Collaborator

Thu Nov 19 14:46:17 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2671/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2671 --build=2

@ukclivecox
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Thu Nov 19 15:30:29 UTC 2020
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2671/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2671 --build=3

Copy link
Contributor

@SachinVarghese SachinVarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@axsaucedo
Copy link
Contributor

/approve

@axsaucedo
Copy link
Contributor

Seems notebooks test is again stuck on tracing test:

release "seldon-core-analytics" uninstalled
FAILED
test_notebooks.py::TestNotebooks::test_tracing [NbConvertApp] Converting notebook ../../examples/models/tracing/tracing.ipynb to script
[NbConvertApp] Writing 4792 bytes to ../../examples/models/tracing/tracing.py

Stopping manually and re-running. also opening an issue as it seems this is happening a few times.
/test notebooks

@seldondev
Copy link
Collaborator

Thu Nov 19 21:07:39 UTC 2020
The logs for [notebooks] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2671/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2671 --build=4

@axsaucedo
Copy link
Contributor

/test notebooks

@seldondev
Copy link
Collaborator

Fri Nov 20 09:39:09 UTC 2020
The logs for [notebooks] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2671/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2671 --build=5

@seldondev seldondev added size/S and removed size/XS labels Nov 20, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo, SachinVarghese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SachinVarghese,axsaucedo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Nov 20 10:15:39 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2671/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2671 --build=7

@seldondev
Copy link
Collaborator

Fri Nov 20 10:15:37 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2671/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2671 --build=6

@seldondev
Copy link
Collaborator

Fri Nov 20 10:35:13 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2671/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2671 --build=8

@seldondev
Copy link
Collaborator

Fri Nov 20 10:35:21 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2671/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2671 --build=9

@ukclivecox
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Fri Nov 20 10:45:25 UTC 2020
The logs for [notebooks] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2671/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2671 --build=10

@seldondev
Copy link
Collaborator

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks a696a42 link /test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ukclivecox
Copy link
Contributor Author

Merging as notebook failures are no to do with this PR.

@ukclivecox ukclivecox merged commit e26df8d into SeldonIO:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explainer wrapper should not add model to path for Tensorflow protocol
4 participants