Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated alibi detect to 0.4.3 #2678

Merged
merged 11 commits into from
Nov 20, 2020

Conversation

axsaucedo
Copy link
Contributor

@axsaucedo axsaucedo commented Nov 19, 2020

Fixes #2667

  • Updated alibidetect image to use alibi detect 0.4.3
  • Retrained cifar10_ks_cd model to 0.4.3
  • Removed p_values from metrics given the detail is not currentl used
  • Tested cifar10 notebook using new image
  • Updated makefile to work with 0.4.3 model
  • Tested outlier detector from makefile working still using 0.4.3 without changes

@axsaucedo axsaucedo added this to the 1.5 milestone Nov 19, 2020
@axsaucedo axsaucedo added this to In progress in 1.5 via automation Nov 19, 2020
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev seldondev added size/M and removed size/S labels Nov 19, 2020
@seldondev
Copy link
Collaborator

Thu Nov 19 20:02:04 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2678/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2678 --build=1

@seldondev
Copy link
Collaborator

Thu Nov 19 20:02:36 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2678/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2678 --build=3

@seldondev
Copy link
Collaborator

Thu Nov 19 20:03:09 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2678/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2678 --build=2

@seldondev
Copy link
Collaborator

Thu Nov 19 20:03:20 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2678/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2678 --build=5

@seldondev
Copy link
Collaborator

Thu Nov 19 20:03:56 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2678/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2678 --build=6

@seldondev
Copy link
Collaborator

Thu Nov 19 20:04:24 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2678/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2678 --build=4

@seldondev
Copy link
Collaborator

Fri Nov 20 10:26:47 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2678/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2678 --build=8

@seldondev
Copy link
Collaborator

Fri Nov 20 10:27:00 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2678/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2678 --build=7

@seldondev
Copy link
Collaborator

Fri Nov 20 10:37:37 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2678/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2678 --build=10

@seldondev
Copy link
Collaborator

Fri Nov 20 10:37:52 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2678/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2678 --build=9

@seldondev
Copy link
Collaborator

Fri Nov 20 13:00:11 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2678/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2678 --build=11

@seldondev
Copy link
Collaborator

Fri Nov 20 13:00:09 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2678/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2678 --build=12

@seldondev
Copy link
Collaborator

Fri Nov 20 13:10:01 UTC 2020
The logs for [pr-build] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2678/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2678 --build=13

@seldondev
Copy link
Collaborator

Fri Nov 20 13:10:07 UTC 2020
The logs for [lint] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2678/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2678 --build=14

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arnaudvl
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@SachinVarghese SachinVarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@axsaucedo axsaucedo merged commit 97013b1 into SeldonIO:master Nov 20, 2020
1.5 automation moved this from In progress to Done Nov 20, 2020
@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref d7b7b4f
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha d7b7b4f
  • failed to process repo SeldonIO/seldon-core refref d7b7b4f
  • failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
  • open /var/tmp/gitrepo660600678/.lighthouse
  • no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
1.5
Done
Development

Successfully merging this pull request may close these issues.

Update metrics exposed by alibi detect server to include all newer components (threshold, etc)
4 participants