Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ambassador doc for shadow deployment #2697

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

anggao
Copy link
Contributor

@anggao anggao commented Nov 23, 2020

What this PR does / why we need it:
seldon.io/ambassador-shadow:true is obsoleted

Which issue(s) this PR fixes:

Fixes #1741

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

Hi @anggao. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@anggao
Copy link
Contributor Author

anggao commented Nov 30, 2020

/cc @cliveseldon

@ukclivecox
Copy link
Contributor

/approve

@ukclivecox ukclivecox merged commit db251e0 into SeldonIO:master Nov 30, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ambassador doc and release doc about shadow model
3 participants