Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy Python2 components #2724

Conversation

RafalSkolasinski
Copy link
Member

What this PR does / why we need it:

Remove some obsolete elements relevant only for Python2.

Which issue(s) this PR fixes:

Closes #1438

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Python 2 compatibility layer removed completely. 

@RafalSkolasinski
Copy link
Member Author

/test
/test integration

@seldondev
Copy link
Collaborator

Mon Nov 30 17:35:59 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2724/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2724 --build=1

@seldondev
Copy link
Collaborator

Mon Nov 30 17:36:07 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2724/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2724 --build=2

@seldondev
Copy link
Collaborator

Mon Nov 30 17:36:14 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2724/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2724 --build=3

@axsaucedo
Copy link
Contributor

Nice one
/approve

@seldondev
Copy link
Collaborator

Tue Dec 1 12:58:38 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2724/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2724 --build=5

@seldondev
Copy link
Collaborator

Tue Dec 1 12:58:39 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2724/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2724 --build=4

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RafalSkolasinski
Copy link
Member Author

/test integration

@seldondev
Copy link
Collaborator

Tue Dec 1 13:04:33 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2724/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2724 --build=6

@seldondev
Copy link
Collaborator

Tue Dec 1 13:05:00 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2724/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2724 --build=8

@seldondev
Copy link
Collaborator

Tue Dec 1 13:05:00 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2724/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2724 --build=7

@seldondev
Copy link
Collaborator

Tue Dec 1 13:05:04 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2724/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2724 --build=10

@seldondev
Copy link
Collaborator

Tue Dec 1 13:06:39 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2724/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2724 --build=9

@axsaucedo axsaucedo removed the approved label Dec 1, 2020
@RafalSkolasinski
Copy link
Member Author

RafalSkolasinski commented Dec 1, 2020

@axsaucedo integration tests passed, shall we?

comparing to first version I undid modification to grpc component as this one is auto-generated

@axsaucedo axsaucedo merged commit 5ac61f9 into SeldonIO:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove legacy Python 2 elements
3 participants