Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2744 R Language Wrapper Fix for JSON requests #2837

Merged
merged 3 commits into from
Jan 16, 2021

Conversation

axsaucedo
Copy link
Contributor

Fixes #2744

@axsaucedo axsaucedo added this to the 1.6 milestone Jan 13, 2021
@axsaucedo axsaucedo added this to In progress in Sprint 1 via automation Jan 13, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

Wed Jan 13 17:16:24 UTC 2021
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2837/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2837 --build=2

@seldondev
Copy link
Collaborator

Wed Jan 13 17:16:27 UTC 2021
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2837/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2837 --build=1

@ukclivecox ukclivecox moved this from In progress to Review in progress in Sprint 1 Jan 14, 2021
@axsaucedo
Copy link
Contributor Author

Tested working with @omerfsen so approving
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Sat Jan 16 07:13:57 UTC 2021
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2837/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2837 --build=3

@seldondev
Copy link
Collaborator

Sat Jan 16 07:13:57 UTC 2021
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2837/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2837 --build=4

@seldondev seldondev merged commit 0aa23d9 into SeldonIO:master Jan 16, 2021
Sprint 1 automation moved this from Review in progress to Done Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Error when using the R language wrapper
2 participants