Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rclone powered batch #2842

Merged
merged 3 commits into from
Jan 15, 2021
Merged

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:

It modifies standard Argo Workflows Batch Example to use rclone for pulling / pushing the inputs / output files for batch processing. This greatly extends compatibility with different cloud storage providers (40+).

Which issue(s) this PR fixes:

Closes #2819

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Jan 15 11:56:45 UTC 2021
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2842/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2842 --build=1

@seldondev
Copy link
Collaborator

Fri Jan 15 11:56:53 UTC 2021
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2842/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2842 --build=2

@omerfsen
Copy link
Contributor

It is great but maybe we can leave this one as-is and use rclone on different example ?

@seldondev
Copy link
Collaborator

Fri Jan 15 12:00:22 UTC 2021
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2842/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2842 --build=3

@seldondev
Copy link
Collaborator

Fri Jan 15 12:00:27 UTC 2021
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2842/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2842 --build=4

@seldondev
Copy link
Collaborator

Fri Jan 15 12:17:07 UTC 2021
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2842/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2842 --build=5

@seldondev
Copy link
Collaborator

Fri Jan 15 12:17:08 UTC 2021
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2842/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2842 --build=6

@axsaucedo axsaucedo merged commit 2e5f30d into SeldonIO:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add example of batch processor with rclone
4 participants