Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Java engine #2857

Merged
merged 7 commits into from
Jan 22, 2021
Merged

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:

This PR removes:

  • Dependabot alerts for Java engine
  • JX context to run Java engine's tests
  • Flag executor.enabled from Seldon Core chart

Which issue(s) this PR fixes:

Fixes #2588

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Deprecated Java engine (service orchestrator).

@adriangonz
Copy link
Contributor Author

/test integration
/cc @RafalSkolasinski @axsaucedo @cliveseldon

@seldondev
Copy link
Collaborator

Wed Jan 20 17:00:11 UTC 2021
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=2

@seldondev
Copy link
Collaborator

Wed Jan 20 17:00:20 UTC 2021
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=1

@seldondev
Copy link
Collaborator

Wed Jan 20 17:00:57 UTC 2021
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=5

@adriangonz
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Wed Jan 20 17:01:01 UTC 2021
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=4

@seldondev
Copy link
Collaborator

Wed Jan 20 17:02:09 UTC 2021
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=3

@seldondev
Copy link
Collaborator

Wed Jan 20 17:02:46 UTC 2021
The logs for [notebooks] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=6

@axsaucedo
Copy link
Contributor

Looks good! Why are there so many reformatting updates? Is this because of the update of black?

@adriangonz
Copy link
Contributor Author

@axsaucedo good question. I'm not sure TBH.

It could be that the linter doesn't check those folders, but the pre-commit handler does? I've got the latter set up in my environment, so maybe that's the one doing the changes.

@axsaucedo
Copy link
Contributor

Ok makes sense @adriangonz

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Jan 21 09:32:55 UTC 2021
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=7

@adriangonz
Copy link
Contributor Author

/test lint
/test notebooks

@seldondev
Copy link
Collaborator

Thu Jan 21 11:38:00 UTC 2021
The logs for [notebooks] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=8

@seldondev
Copy link
Collaborator

Thu Jan 21 11:38:37 UTC 2021
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=9

@seldondev seldondev added size/XL and removed size/L labels Jan 21, 2021
@seldondev
Copy link
Collaborator

Thu Jan 21 16:08:40 UTC 2021
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=10

@seldondev
Copy link
Collaborator

Thu Jan 21 16:08:49 UTC 2021
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=11

@seldondev
Copy link
Collaborator

Thu Jan 21 16:21:11 UTC 2021
The logs for [pr-build] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=12

@seldondev
Copy link
Collaborator

Thu Jan 21 16:21:24 UTC 2021
The logs for [lint] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=13

@seldondev
Copy link
Collaborator

Thu Jan 21 16:55:30 UTC 2021
The logs for [lint] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=15

@seldondev
Copy link
Collaborator

Thu Jan 21 16:58:23 UTC 2021
The logs for [pr-build] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=14

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Jan 21 17:09:04 UTC 2021
The logs for [integration] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=16

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Fri Jan 22 10:05:16 UTC 2021
The logs for [integration] [17] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/17.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=17

@axsaucedo
Copy link
Contributor

Looks good!
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Jan 22 13:50:59 UTC 2021
The logs for [lint] [19] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/19.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=19

@seldondev
Copy link
Collaborator

Fri Jan 22 13:51:21 UTC 2021
The logs for [pr-build] [18] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/18.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=18

@seldondev
Copy link
Collaborator

Fri Jan 22 14:14:55 UTC 2021
The logs for [lint] [21] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/21.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=21

@seldondev
Copy link
Collaborator

Fri Jan 22 14:14:54 UTC 2021
The logs for [pr-build] [20] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/20.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=20

@adriangonz
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Fri Jan 22 14:48:44 UTC 2021
The logs for [pr-build] [22] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2857/22.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2857 --build=22

@seldondev seldondev merged commit b881f99 into SeldonIO:master Jan 22, 2021
@adriangonz adriangonz deleted the deprecate-java-engine branch January 22, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depricate engine (old Java service orchestrator)
3 participants