-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Java engine #2857
Deprecate Java engine #2857
Conversation
/test integration |
Wed Jan 20 17:00:11 UTC 2021 impatient try |
Wed Jan 20 17:00:20 UTC 2021 impatient try |
Wed Jan 20 17:00:57 UTC 2021 impatient try |
/test notebooks |
Wed Jan 20 17:01:01 UTC 2021 impatient try |
Wed Jan 20 17:02:09 UTC 2021 impatient try |
Wed Jan 20 17:02:46 UTC 2021 impatient try |
Looks good! Why are there so many reformatting updates? Is this because of the update of |
@axsaucedo good question. I'm not sure TBH. It could be that the linter doesn't check those folders, but the pre-commit handler does? I've got the latter set up in my environment, so maybe that's the one doing the changes. |
Ok makes sense @adriangonz |
/test integration |
Thu Jan 21 09:32:55 UTC 2021 impatient try |
/test lint |
Thu Jan 21 11:38:00 UTC 2021 impatient try |
Thu Jan 21 11:38:37 UTC 2021 impatient try |
Thu Jan 21 16:08:40 UTC 2021 impatient try |
Thu Jan 21 16:08:49 UTC 2021 impatient try |
Thu Jan 21 16:21:11 UTC 2021 impatient try |
Thu Jan 21 16:21:24 UTC 2021 impatient try |
Thu Jan 21 16:55:30 UTC 2021 impatient try |
Thu Jan 21 16:58:23 UTC 2021 impatient try |
/test integration |
Thu Jan 21 17:09:04 UTC 2021 impatient try |
/test integration |
Fri Jan 22 10:05:16 UTC 2021 impatient try |
Looks good! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fri Jan 22 13:50:59 UTC 2021 impatient try |
Fri Jan 22 13:51:21 UTC 2021 impatient try |
Fri Jan 22 14:14:55 UTC 2021 impatient try |
Fri Jan 22 14:14:54 UTC 2021 impatient try |
/test this |
Fri Jan 22 14:48:44 UTC 2021 impatient try |
What this PR does / why we need it:
This PR removes:
executor.enabled
from Seldon Core chartWhich issue(s) this PR fixes:
Fixes #2588
Special notes for your reviewer:
Does this PR introduce a user-facing change?: