Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove managedFields from seldon pod spec metadata #2954

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

ivan-valkov
Copy link
Contributor

@ivan-valkov ivan-valkov commented Feb 15, 2021

What this PR does / why we need it:
Otherwise applying the crd can fail with:

Error: CustomResourceDefinition.apiextensions.k8s.io "seldondeployments.machinelearning.seldon.io" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[predictors].items.properties[componentSpecs].items.properties[metadata].properties[managedFields].items.properties[fieldsV1].type: Unsupported value: "Any": supported values: "array", "boolean", "integer", "number", "object", "string"

Which issue(s) this PR fixes:

Related to #2938

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@ivan-valkov ivan-valkov force-pushed the fix-1.5.2-crds branch 3 times, most recently from 84d5afc to e1b45d0 Compare February 15, 2021 11:23
@ivan-valkov
Copy link
Contributor Author

/test

@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref 9e77b16
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha 9e77b16
  • failed to process repo SeldonIO/seldon-core refref 9e77b16
  • failed to list files in directory /var/tmp/gitrepo059637228/.lighthouse
  • open /var/tmp/gitrepo059637228/.lighthouse
  • no such file or directory

@ivan-valkov
Copy link
Contributor Author

/test integration
/test notebooks

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ivan-valkov
You can assign the PR to them by writing /assign @ivan-valkov in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RafalSkolasinski
Copy link
Contributor

/test notebooks
/test integration

@ivan-valkov
Copy link
Contributor Author

/retest

@ivan-valkov
Copy link
Contributor Author

/test notebooks
/test integration

@ivan-valkov
Copy link
Contributor Author

/test integration

@ivan-valkov
Copy link
Contributor Author

/test integration

@ivan-valkov
Copy link
Contributor Author

/test notebooks

2 similar comments
@ivan-valkov
Copy link
Contributor Author

/test notebooks

@ivan-valkov
Copy link
Contributor Author

/test notebooks

@ivan-valkov
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

@ivan-valkov: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks 5fb02ab link /test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ukclivecox ukclivecox merged commit eb7185f into SeldonIO:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants