Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elasticsearch index #2972

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

fg91
Copy link
Contributor

@fg91 fg91 commented Feb 16, 2021

What this PR does / why we need it:

The elasticsearch_index = f"inference-log-{seldon_namespace}-seldon-... of the metrics server is only correct if the namespace of the model happens to be seldon as the the elasticsearch index is called 'inference-log-seldon-<namespace>...'

Which issue(s) this PR fixes:
Fixes #2971

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

None

@seldondev
Copy link
Collaborator

Hi @fg91. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@ryandawsonuk
Copy link
Contributor

@fg91 yes you're right, serving engine should come before namespace as it does in the request logger code
https://github.com/SeldonIO/seldon-core/blob/master/components/seldon-request-logger/app/log_helper.py#L44

And is mentioned in its README

/lgtm
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ryandawsonuk
Copy link
Contributor

/ok-to-test

@seldondev seldondev merged commit 5b5369f into SeldonIO:master Feb 17, 2021
@fg91 fg91 deleted the fabio-fix-elasticsearch-index branch February 17, 2021 08:26
@ryandawsonuk ryandawsonuk mentioned this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in elasticsearch index of metrics server
3 participants