Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small improvements to metrics server example #2989

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

ryandawsonuk
Copy link
Contributor

@ryandawsonuk ryandawsonuk commented Feb 25, 2021

I noticed https://github.com/SeldonIO/seldon-core/tree/master/examples/feedback/metrics-server was using an old version of knative so I thought I would update it... then I realised it doesn't really use knative at all as the logger uri points directly at the metrics server.

So instead I removed knative from this particular example. If people want to see the knative flow they can use the simlar example https://github.com/SeldonIO/seldon-core/tree/master/examples/feedback/feedback-metrics-server (and have added a note saying this). This makes it a bit easier both to run and to maintain.

Have run the notebook through and all works (which makes sense as haven't really made a substantial change here).

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ryandawsonuk
You can assign the PR to them by writing /assign @ryandawsonuk in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 61ab8f9 into SeldonIO:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants