Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook tests/metrics server port 8003 #3015

Conversation

RafalSkolasinski
Copy link
Contributor

Fix port in metrics-server example - it uses 8080 instead of usual 8003.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RafalSkolasinski RafalSkolasinski force-pushed the notebook-tests/metrics-server-port-8003 branch from f44fdf5 to 4c90e7a Compare March 4, 2021 12:19
@RafalSkolasinski
Copy link
Contributor Author

Testing notebooks only (only change to one notebook).

/test notebooks

@RafalSkolasinski RafalSkolasinski merged commit 62b88b6 into SeldonIO:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants