Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add helm v3 commands #3045

Merged
merged 1 commit into from
Mar 11, 2021
Merged

docs: add helm v3 commands #3045

merged 1 commit into from
Mar 11, 2021

Conversation

masonlr
Copy link
Contributor

@masonlr masonlr commented Mar 10, 2021

What this PR does / why we need it:

This PR updates instances of helm install in the docs to be compatible with Helm v3 (the --name foo option for Helm release names is not supported in Helm v3 and the release name is now a positional argument).

This PR updates the docs, but doesn't update remaining Helm v2 statements in the following scripts/Makefiles:

@cliveseldon if you let me know I can update the scripts/Makefiles above to be compatible with Helm v3 as well – I'm not certain whether these are currently in use, particularly start-seldon-core-private-repo, so have left them alone.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

There is a separete PR that deals with similar changes to Istio content: #3044

For reference, the initial discussion was on Slack here: https://seldondev.slack.com/archives/CSVSD5S75/p1610047087283500?thread_ts=1609611010.277400&cid=CSVSD5S75

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

Hi @masonlr. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

This is great - thanks @masonlr !

@ukclivecox ukclivecox merged commit 881e9fa into SeldonIO:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants