Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates instances of
helm install
in the docs to be compatible with Helm v3 (the--name foo
option for Helm release names is not supported in Helm v3 and the release name is now a positional argument).This PR updates the docs, but doesn't update remaining Helm v2 statements in the following scripts/Makefiles:
@cliveseldon if you let me know I can update the scripts/Makefiles above to be compatible with Helm v3 as well – I'm not certain whether these are currently in use, particularly start-seldon-core-private-repo, so have left them alone.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
There is a separete PR that deals with similar changes to Istio content: #3044
For reference, the initial discussion was on Slack here: https://seldondev.slack.com/archives/CSVSD5S75/p1610047087283500?thread_ts=1609611010.277400&cid=CSVSD5S75
Does this PR introduce a user-facing change?: