Request Logger JsonData Fix #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, changes look good to me. And returning the elastic response is really useful for debugging. |
axsaucedo
reviewed
Jul 22, 2021
| @@ -7,8 +7,8 @@ CLIENT_ID=sd-api | |||
| OIDC_USERNAME=admin@seldon.io | |||
| OIDC_PASSWORD=xxxxxx | |||
| OIDC_SCOPES=openid profile email groups | |||
| DEPLOY_API_HOST=http://xx.xx.xx.xx/seldon-deploy/api/v1alpha1 | |||
| OIDC_PROVIDER=http://xx.xx.xx.xx/auth/realms/deploy-realm | |||
| #DEPLOY_API_HOST=http://xx.xx.xx.xx/seldon-deploy/api/v1alpha1 | |||
There was a problem hiding this comment.
I commented out so as not to assume deploy exists when running locally but should really improve Makefile for the 2 options of running with and without deploy
|
Looks good added a comment for somethign to consider but we can merge as follow refactor |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3421
Special notes for your reviewer:
Does this PR introduce a user-facing change?: