Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing trailing slash to tensorflow serving URL in status addressable #3431

Merged
merged 2 commits into from Jul 28, 2021

Conversation

axsaucedo
Copy link
Contributor

What this PR does / why we need it:

Currently the status addressable for tensorflow serving url contains a trailing slash in the form of model/:predict, whereas it should be without the trailing slash as model:predict. This PR updates the status addressable to reflect this.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@axsaucedo
Copy link
Contributor Author

/test integration

@axsaucedo
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor

/test notebooks

@axsaucedo
Copy link
Contributor Author

/test notebooks

@axsaucedo
Copy link
Contributor Author

/test integration

@axsaucedo
Copy link
Contributor Author

Custom metrics failed which is flaky so rerunning
/test notebooks

@axsaucedo
Copy link
Contributor Author

/test notebooks

@ukclivecox ukclivecox merged commit ab1da68 into SeldonIO:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants