Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python38 #3475

Merged
merged 6 commits into from Aug 10, 2021
Merged

Python38 #3475

merged 6 commits into from Aug 10, 2021

Conversation

RafalSkolasinski
Copy link
Member

What this PR does / why we need it:
This adds Python 3.8 s2i wrapper.

Which issue(s) this PR fixes:

Closes #1230

Special notes for your reviewer:
Simplified build process -> all logic is now is now in build_all.sh and push_all.sh images.

Does this PR introduce a user-facing change?:

@RafalSkolasinski
Copy link
Member Author

/test integration

@RafalSkolasinski
Copy link
Member Author

/test notebooks

@RafalSkolasinski
Copy link
Member Author

/test integration

@RafalSkolasinski
Copy link
Member Author

/test notebooks

@RafalSkolasinski
Copy link
Member Author

/test integration

1 similar comment
@RafalSkolasinski
Copy link
Member Author

/test integration

@RafalSkolasinski
Copy link
Member Author

/test integration

@RafalSkolasinski
Copy link
Member Author

/test integration

@RafalSkolasinski
Copy link
Member Author

/test release

@RafalSkolasinski
Copy link
Member Author

/test notebooks

@RafalSkolasinski
Copy link
Member Author

/test this

@seldondev
Copy link
Collaborator

seldondev commented Aug 9, 2021

@RafalSkolasinski: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
release-build-push d353bb3 link /test release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@RafalSkolasinski
Copy link
Member Author

/test notebooks

@axsaucedo
Copy link
Contributor

Nice one - looks good
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 49994f8 into SeldonIO:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seldon wrapper image with python 3.8
3 participants