Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master alibi detect #3491

Merged
merged 3 commits into from Aug 17, 2021

Conversation

RafalSkolasinski
Copy link
Member

@RafalSkolasinski RafalSkolasinski commented Aug 16, 2021

What this PR does / why we need it:

  • fix Alibi Detect Server dependency issues
  • fix images used in alibi detect server tests
  • include version of images in release.py

Releates to #3490

Which issue(s) this PR fixes:

Closes #3488

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RafalSkolasinski
Copy link
Member Author

/test integration

4 similar comments
@RafalSkolasinski
Copy link
Member Author

/test integration

@RafalSkolasinski
Copy link
Member Author

/test integration

@RafalSkolasinski
Copy link
Member Author

/test integration

@RafalSkolasinski
Copy link
Member Author

/test integration

@axsaucedo
Copy link
Contributor

Failing alibi detect test is confirmed flaky as it has now been testsed both locally and inside the CI itself. The flakiness reason has not been identified, but will be investigated separate to the release.
image

@axsaucedo axsaucedo merged commit d75ab8c into SeldonIO:master Aug 17, 2021
@seldondev
Copy link
Collaborator

@RafalSkolasinski: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration a67a13e link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fix for conflicting tensorflow version for Alibi Detect Server
3 participants