Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra comma in kustomize operator configmap #3693

Merged
merged 1 commit into from Oct 25, 2021
Merged

Fix extra comma in kustomize operator configmap #3693

merged 1 commit into from Oct 25, 2021

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3652

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration fc4fb80 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor

Looks good - tested locally (seems no difference on the helm charts) and all integration tests pass so should be good to merge
/approve

@axsaucedo axsaucedo merged commit 5a5df2f into SeldonIO:master Oct 25, 2021
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seldon Manager Config Map has an extra comma that can cause parsing error
3 participants