Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MLServer image to 1.0.0.rc1 #3795

Merged
merged 4 commits into from Dec 9, 2021
Merged

Bump MLServer image to 1.0.0.rc1 #3795

merged 4 commits into from Dec 9, 2021

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:
Bump MLServer image to 1.0.0.rc1 release candidate.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@adriangonz adriangonz changed the title Bump MLServer imager to 1.0.0.rc1 Bump MLServer image to 1.0.0.rc1 Dec 7, 2021
@adriangonz
Copy link
Contributor Author

/test integration

@axsaucedo
Copy link
Contributor

Nice one
/approve

@axsaucedo
Copy link
Contributor

@adriangonz seems one failure on test_alibi_explain_anchor_image_triton, assuming that because of triton it most likely would be due to context deadline exceeded, but would be good to validate locally - if it passes locally we should be good to merge. We should probably add an issue to make sure we add that prior download of the triton image to avoid the timeout across the various tests

@axsaucedo
Copy link
Contributor

/hold

sakoush
sakoush reviewed Dec 8, 2021
View reviewed changes
helm-charts/seldon-core-operator/values.yaml
@@ -206,4 +206,4 @@ engine:
# Explainer image
explainer:
image: seldonio/alibiexplainer:1.12.0-dev
image_v2: seldonio/mlserver:0.6.0.dev4
image_v2: seldonio/mlserver:1.0.0.rc1-alibi-explain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havent tested this specifically with just alibi-explain runtime but hopefully the integration test will run the tests needed to confirm that.

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

@adriangonz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 659e334 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 6dfd0d9 into SeldonIO:master Dec 9, 2021
stephen37 pushed a commit to stephen37/seldon-core that referenced this pull request Dec 21, 2021
Bump MLServer image to 1.0.0.rc1 (SeldonIO#3795)
4ff6e28 
* Bump mlserver to 0.6.0.dev5

* Use MLflow demo artifact from v1.12.0-dev

* Bump mlserver to 1.0.0.rc1

* Fix test data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakoush sakoush sakoush left review comments

@axsaucedo axsaucedo Awaiting requested review from axsaucedo

Assignees
No one assigned
Labels
approved do-not-merge/hold size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adriangonz @axsaucedo @seldondev @sakoush