Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update conda in base image and use ubi9 #4329

Merged
merged 2 commits into from Sep 14, 2022
Merged

update conda in base image and use ubi9 #4329

merged 2 commits into from Sep 14, 2022

Conversation

RafalSkolasinski
Copy link
Member

@RafalSkolasinski RafalSkolasinski commented Sep 8, 2022 •
edited

  • update conda to 4.14 and install final version earlier
  • use ubi9 for base image

@RafalSkolasinski RafalSkolasinski marked this pull request as draft September 8, 2022 14:58
@RafalSkolasinski
Copy link
Member Author

/test integration

@RafalSkolasinski
Copy link
Member Author

/test notebooks

@RafalSkolasinski
Copy link
Member Author

/test integration

@seldondev seldondev added size/S and removed size/XS labels Sep 8, 2022
@RafalSkolasinski
Copy link
Member Author

/test notebooks

@RafalSkolasinski RafalSkolasinski changed the title update conda in base image update conda in base image and use ubi9 Sep 8, 2022
@RafalSkolasinski
Copy link
Member Author

/retest

2 similar comments
@RafalSkolasinski
Copy link
Member Author

/retest

@RafalSkolasinski
Copy link
Member Author

/retest

@axsaucedo
Copy link
Contributor

/test integration

1 similar comment
@RafalSkolasinski
Copy link
Member Author

/test integration

@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review September 12, 2022 10:50
@RafalSkolasinski
Copy link
Member Author

though it was only initial exploration this is probably good to be merged now once the integration and notebook tests have passed

@RafalSkolasinski
Copy link
Member Author

image

@axsaucedo
Copy link
Contributor

Nice one @RafalSkolasinski - merging

/approve

@axsaucedo axsaucedo merged commit 0f82243 into SeldonIO:master Sep 14, 2022
@axsaucedo
Copy link
Contributor

@RafalSkolasinski may be worth adding a note in the upgrading page

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RafalSkolasinski @axsaucedo @seldondev