introduce Snyk security scans for V2 images #4575
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,189 @@ | ||
| name: V2 Security Tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ v2 ] | ||
| workflow_dispatch: | ||
| inputs: | ||
| docker-tag: | ||
| description: 'Docker tag for scan' | ||
| default: 'latest' | ||
| required: false | ||
|
|
||
| jobs: | ||
| security-operator: | ||
| runs-on: ubuntu-latest | ||
| container: snyk/snyk:golang | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: security-golang | ||
| env: | ||
| SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} | ||
| run: | | ||
| make -C operator fmt | ||
| snyk test --file=operator/go.mod --fail-on=upgradable --severity-threshold=high | ||
|
|
||
| security-scheduler: | ||
| runs-on: ubuntu-latest | ||
| container: snyk/snyk:golang | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: security-golang | ||
| env: | ||
| SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} | ||
| run: | | ||
| make -C scheduler lint | ||
| snyk test --file=scheduler/go.mod --fail-on=upgradable --severity-threshold=high | ||
|
|
||
| security-image-operator: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set default docker tag for builds from v2 branch | ||
| id: docker-tag | ||
| run: | | ||
| USER_INPUT="${{ github.event.inputs.docker-tag }}" | ||
| echo ::set-output name=value::${USER_INPUT:-"latest"} | ||
|
There was a problem hiding this comment. Oh wow - is this wizardry to default to There was a problem hiding this comment. Yeah, that's to use default for input usually coming as parameter to "on_dispatch" in workflows running "on_push". There may be more elegant way (though I doubt, unless some new features were added) but that is what I found when working on SCv2 release workflow. |
||
| - name: security-docker-image | ||
| uses: snyk/actions/docker@master | ||
| env: | ||
| SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} | ||
| with: | ||
| image: seldonio/seldonv2-controller:${{ steps.docker-tag.outputs.value }} | ||
| args: --fail-on=upgradable --severity-threshold=high --file=operator/Dockerfile | ||
|
|
||
| security-image-scheduler: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set default docker tag for builds from v2 branch | ||
| id: docker-tag | ||
| run: | | ||
| USER_INPUT="${{ github.event.inputs.docker-tag }}" | ||
| echo ::set-output name=value::${USER_INPUT:-"latest"} | ||
| - name: security-docker-image | ||
| uses: snyk/actions/docker@master | ||
| env: | ||
| SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} | ||
| with: | ||
| image: seldonio/seldon-scheduler:${{ steps.docker-tag.outputs.value }} | ||
| args: --fail-on=upgradable --severity-threshold=high --file=scheduler/Dockerfile.scheduler | ||
|
|
||
| security-image-data-flow-engine: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set default docker tag for builds from v2 branch | ||
| id: docker-tag | ||
| run: | | ||
| USER_INPUT="${{ github.event.inputs.docker-tag }}" | ||
| echo ::set-output name=value::${USER_INPUT:-"latest"} | ||
| - name: security-docker-image | ||
| uses: snyk/actions/docker@master | ||
| env: | ||
| SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} | ||
| with: | ||
| image: seldonio/seldon-dataflow-engine:${{ steps.docker-tag.outputs.value }} | ||
| args: --fail-on=upgradable --severity-threshold=high --file=scheduler/Dockerfile.dataflow | ||
|
|
||
| security-image-envoy: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set default docker tag for builds from v2 branch | ||
| id: docker-tag | ||
| run: | | ||
| USER_INPUT="${{ github.event.inputs.docker-tag }}" | ||
| echo ::set-output name=value::${USER_INPUT:-"latest"} | ||
| - name: security-docker-image | ||
| uses: snyk/actions/docker@master | ||
| env: | ||
| SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} | ||
| with: | ||
| image: seldonio/seldon-envoy:${{ steps.docker-tag.outputs.value }} | ||
| args: --fail-on=upgradable --severity-threshold=high --file=scheduler/Dockerfile.envoy | ||
|
|
||
| security-image-modelgateway: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set default docker tag for builds from v2 branch | ||
| id: docker-tag | ||
| run: | | ||
| USER_INPUT="${{ github.event.inputs.docker-tag }}" | ||
| echo ::set-output name=value::${USER_INPUT:-"latest"} | ||
| - name: security-docker-image | ||
| uses: snyk/actions/docker@master | ||
| env: | ||
| SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} | ||
| with: | ||
| image: seldonio/seldon-modelgateway:${{ steps.docker-tag.outputs.value }} | ||
| args: --fail-on=upgradable --severity-threshold=high --file=scheduler/Dockerfile.modelgateway | ||
|
|
||
| security-image-pipelinegateway: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set default docker tag for builds from v2 branch | ||
| id: docker-tag | ||
| run: | | ||
| USER_INPUT="${{ github.event.inputs.docker-tag }}" | ||
| echo ::set-output name=value::${USER_INPUT:-"latest"} | ||
| - name: security-docker-image | ||
| uses: snyk/actions/docker@master | ||
| env: | ||
| SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} | ||
| with: | ||
| image: seldonio/seldon-pipelinegateway:${{ steps.docker-tag.outputs.value }} | ||
| args: --fail-on=upgradable --severity-threshold=high --file=scheduler/Dockerfile.pipelinegateway | ||
|
|
||
| security-image-agent: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set default docker tag for builds from v2 branch | ||
| id: docker-tag | ||
| run: | | ||
| USER_INPUT="${{ github.event.inputs.docker-tag }}" | ||
| echo ::set-output name=value::${USER_INPUT:-"latest"} | ||
| - name: security-docker-image | ||
| uses: snyk/actions/docker@master | ||
| env: | ||
| SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} | ||
| with: | ||
| image: seldonio/seldon-agent:${{ steps.docker-tag.outputs.value }} | ||
| args: --fail-on=upgradable --severity-threshold=high --file=scheduler/Dockerfile.agent | ||
|
|
||
| security-image-rclone: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set default docker tag for builds from v2 branch | ||
| id: docker-tag | ||
| run: | | ||
| USER_INPUT="${{ github.event.inputs.docker-tag }}" | ||
| echo ::set-output name=value::${USER_INPUT:-"latest"} | ||
| - name: security-docker-image | ||
| uses: snyk/actions/docker@master | ||
| env: | ||
| SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} | ||
| with: | ||
| image: seldonio/seldon-rclone:${{ steps.docker-tag.outputs.value }} | ||
| args: --fail-on=upgradable --severity-threshold=high --file=scheduler/Dockerfile.rclone | ||
|
|
||
| security-image-hodometer: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set default docker tag for builds from v2 branch | ||
| id: docker-tag | ||
| run: | | ||
| USER_INPUT="${{ github.event.inputs.docker-tag }}" | ||
| echo ::set-output name=value::${USER_INPUT:-"latest"} | ||
| - name: security-docker-image | ||
| uses: snyk/actions/docker@master | ||
| env: | ||
| SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} | ||
| with: | ||
| image: seldonio/seldon-hodometer:${{ steps.docker-tag.outputs.value }} | ||
| args: --fail-on=upgradable --severity-threshold=high --file=hodometer/Dockerfile.hodometer | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why need to run the linter here, instead of using Snyk's GH action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all other tasks there was
make -C <directory> fmtbutschedulerdid not havefmtbutlintcommand. Not sure exactly why it is there. I first assumed it was for Go to pull modules but that does not make sense actually... I may try without it.But to why these are here: it's because these were present in V1 tasks.