Docs: Add a section in Servers for setting extra capabilities #4718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrski
reviewed
Mar 9, 2023
agrski
reviewed
Mar 9, 2023
agrski
approved these changes
Mar 9, 2023
agrski
reviewed
Mar 9, 2023
| ```{literalinclude} ../../../../samples/servers/mlserver-extra-capabilities.yaml | ||
| :language: yaml | ||
| ``` | ||
| Note that `serverConfig: mlserver` will provide default capabilities for MLServer as shown above, and the values specified in `extraCapabilities` are appended to them to create a single list of capabilities. |
There was a problem hiding this comment.
Suggested change
| Note that `serverConfig: mlserver` will provide default capabilities for MLServer as shown above, and the values specified in `extraCapabilities` are appended to them to create a single list of capabilities. | |
| Note that `serverConfig: mlserver` will provide default capabilities for MLServer as shown above, and the values specified in `extraCapabilities` are appended to them to create a single list of capabilities for this `Server`. |
There was a problem hiding this comment.
Suggested change
| Note that `serverConfig: mlserver` will provide default capabilities for MLServer as shown above, and the values specified in `extraCapabilities` are appended to them to create a single list of capabilities. | |
| This server, `mlserver-extra`, inherits a default set of capabilities via `serverConfig: mlserver`. | |
| These defaults are discussed above. | |
| The `extraCapabilities` are appended to these to create a single list of capabilities for this server. |
Alternative suggestion that perhaps read better?
There was a problem hiding this comment.
Yes the second suggestion reads better. I added a new commit suggestion below myself as I couldn't apply it to the outdated file.
Co-authored-by: Alex Rakowski <20504869+agrski@users.noreply.github.com>
KengoA
commented
Mar 10, 2023
ukclivecox
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a section in
Serverspage explaining how to setextraCapabilitiesfor servers andrequirementsfor models.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: