refactor(dataflow): Refactor conversion to binary contents #4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrski
force-pushed
the
refactor-binary-contents-handling
branch
from
e62b1fe
to
c1018e3
Compare
This has two key benefits. Firstly, the same conversion logic was used for both requests and responses. Thus, we are removing duplication and minimising the risk of differences creeping in. Secondly, the business is easier to read, as the handling is moved outside.
This order is defined by the specification, so we should not allow for it to change. https://github.com/triton-inference-server/server/blob/c47b2392a4f81a35f88d416f3356eec60ff83dbf/docs/protocol/extension_binary_data.md#binary-tensor-request
agrski
force-pushed
the
refactor-binary-contents-handling
branch
from
c1018e3
to
5cc1e80
Compare
ukclivecox
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Following on from #4781, this PR refactors that code to be more idiomatic and easier to read.
Changes include:
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
I've tested with the
pipeline-examplesnotebook and find the same results forseldon pipeline inspectcommands as in #4781.