ignore pickle files #483
Merged
ignore pickle files #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed these are generated when running some notebooks. Some other projects are ignoring e.g.
https://github.com/enigmampc/catalyst/blob/master/.gitignore#L75
In our case sometimes we have files committed:
https://github.com/SeldonIO/seldon-core/tree/ignore-pickle-files/components/outlier-detection/seq2seq-lstm/models
But for the isolation forest notebook. I end up with a models/if.pickle file being generated locally.
I suspect we want to remove the existing pickle files and add to gitignore but not totally sure - raising this get feedback.