Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hodometer enable flag and docs #5025

Merged
merged 2 commits into from Jul 13, 2023
Merged

fix: hodometer enable flag and docs #5025

merged 2 commits into from Jul 13, 2023

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Jul 13, 2023 •
edited

  • Fix docs for hodometer disable
  • Remove enable flag from setup chart as hodometer can be disabled from runtime chart now

Fixes: #5021

@ukclivecox ukclivecox added the v2 label Jul 13, 2023
@ukclivecox ukclivecox requested a review from agrski July 13, 2023 17:58
agrski
agrski reviewed Jul 13, 2023
View reviewed changes
k8s/Makefile
@@ -16,11 +16,7 @@ create-helm-charts:
kustomize build kustomize/helm-components-ns/ > ${HELM_COMPONENTS_BASE}/seldon-v2-components.yaml
kustomize build kustomize/helm-servers/ > ${HELM_SERVERS_BASE}/seldon-v2-servers.yaml
sed -i 's/\(.*\)\(imagePullSecrets:\).*/{{- with .Values.imagePullSecrets }}\n\1\2\n\1{{- toYaml . | nindent 8 }}\n{{- end }}/g' ${HELM_COMPONENTS_BASE}/seldon-v2-components.yaml
sed -n --file=add-helm-toggle-hodometer.sed ${HELM_COMPONENTS_BASE}/seldon-v2-components.yaml \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 As we don't need the magical sed script any more, that can be deleted (as much as it saddens me to see it go!)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in a7511fb

agrski
agrski reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from removing the now-defunct sed script

@ukclivecox ukclivecox merged commit ea5f5d4 into SeldonIO:v2 Jul 13, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrski agrski agrski approved these changes

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ukclivecox @agrski