fix(operator): consistent pod service monitors reconcilor app labels #5073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelcheah
changed the title
michaelcheah
changed the title
ukclivecox
approved these changes
Aug 9, 2023
RafalSkolasinski
requested changes
Aug 9, 2023
RafalSkolasinski
approved these changes
Aug 10, 2023
k8s/helm-charts/seldon-core-v2-setup/templates/seldon-v2-components.yaml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The default
matchLabelconfigs for Prometheuspodmonitors do not match what is configured by theSeldonRuntimeoperator for several resources.This PR:
app.kubernetes.io/namekey instead ofappto reference seldon componentsseldon-meshis outdated and is updated toseldon-envoy.mlserveris not defined (it is defined for thetritonserver). We expose it on port 8082 which is the default formlserverWhich issue(s) this PR fixes:
Fixes #5071
Special notes for your reviewer: