test: Ensure agent client starts #5112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesse-c
commented
Aug 30, 2023
| @@ -24,19 +24,19 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/envoyproxy/go-control-plane/pkg/cache/v3" | |||
| serverv3 "github.com/envoyproxy/go-control-plane/pkg/server/v3" | |||
| envoyServerControlPlaneV3 "github.com/envoyproxy/go-control-plane/pkg/server/v3" | |||
There was a problem hiding this comment.
explanation: The numbering was confusing
jesse-c
commented
Aug 30, 2023
| } | ||
|
|
||
| err = as.StartGrpcServer(allowPlaintxt, agentPort, agentMtlsPort) | ||
| if err != nil { | ||
| log.Fatalf("Failed to start agent grpc server %s", err.Error()) | ||
| log.WithError(err).Fatalf("Failed to start agent gRPC server") |
There was a problem hiding this comment.
explanation: Everywhere else used WithError
jesse-c
commented
Aug 30, 2023
scheduler/docs/design.md
Outdated
There was a problem hiding this comment.
explanation: A mix of spelling and grammatical improvements
jesse-c
commented
Aug 30, 2023
| @@ -677,8 +679,9 @@ func (c *Client) sendModelEventError( | |||
| event agent.ModelEventMessage_Event, | |||
| err error, | |||
| ) { | |||
| c.logger.WithError(err).Errorf("Failed to load model, sending error to scheduler") | |||
There was a problem hiding this comment.
explanation: Extra verbose logging that was helpful to me when investigating an issue
jesse-c
commented
Aug 30, 2023
There was a problem hiding this comment.
explanation: This change, and the similar ones below, were reported by structcheck
ukclivecox
approved these changes
Aug 30, 2023
I've also added some comments based on my understanding of the code.
jesse-c
force-pushed
the
test-agent-client-comments
branch
from
a0211c1
to
4e03bb6
Compare
adriangonz
pushed a commit
that referenced
this pull request
Sep 1, 2023
I've also added some comments based on my understanding of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I've also added some comments based on my understanding of the code. Along with this, I've added another assertion to the tests, and also made the code more readable.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
The readability changes are purely imho and I'm not beholden to them.