Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(kafka): change message.max.bytes in broker side to align with producer and consumer #5126

Merged
merged 3 commits into from Sep 5, 2023

Conversation

adriangonz
Copy link
Contributor

@adriangonz adriangonz commented Sep 5, 2023

What this PR does / why we need it:
Currently, the Kafka producers and consumers all share the same increased message.max.bytes setting. However, this is not set at the broker level. This can cause errors when payloads too large get rejected by the broker (e.g. see #5125 ).

This PR changes the default value of that setting to align with the config of the producers and consumers - as well as increasing the memory resources allocated to the Kafka broker to account for the new max.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@adriangonz adriangonz added the v2 label Sep 5, 2023
@adriangonz adriangonz marked this pull request as draft September 5, 2023 08:43
@adriangonz adriangonz marked this pull request as ready for review September 5, 2023 13:20
scheduler/all-base.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriangonz adriangonz merged commit 89de4f9 into SeldonIO:v2 Sep 5, 2023
4 of 5 checks passed
@adriangonz adriangonz deleted the change-broker-max branch September 5, 2023 15:56
RafalSkolasinski pushed a commit that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants