Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Auto-detected typos #5135

Merged
merged 2 commits into from Sep 19, 2023
Merged

fix(docs): Auto-detected typos #5135

merged 2 commits into from Sep 19, 2023

Conversation

jesse-c
Copy link
Member

@jesse-c jesse-c commented Sep 19, 2023

These were detected with typos [1].

[1] https://github.com/crate-ci/typos

@jesse-c jesse-c self-assigned this Sep 19, 2023
KengoA
KengoA approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@KengoA KengoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits and grammar fixes but overall LGTM

agrski
agrski approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Presumably the exact invocation was typos -w docs/? I've just installed with asdf and have the same set of files changed if I use that invocation.

@jesse-c
Copy link
Member Author

jesse-c commented Sep 19, 2023

@agrski: That's correct! I manually went through each diff, since I had some false positives in another repo.

@jesse-c @KengoA
Apply suggestions from code review
0029722 
Co-authored-by: Kengo <20113339+KengoA@users.noreply.github.com>
@jesse-c
Copy link
Member Author

jesse-c commented Sep 19, 2023

@KengoA: Great additions, thank you!

@jesse-c jesse-c merged commit 9aa41ef into SeldonIO:v2 Sep 19, 2023
4 of 5 checks passed
@jesse-c jesse-c deleted the jc/v2/typos-cli-fix branch September 19, 2023 14:25
RafalSkolasinski pushed a commit that referenced this pull request Jan 22, 2024
@jesse-c @KengoA @sakoush
fix(docs): Auto-detected typos (#5135)
ef5d604 
* fix(docs): Auto-detected typos

These were detected with typos [1].

[1] https://github.com/crate-ci/typos

Co-authored-by: Kengo <20113339+KengoA@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KengoA KengoA KengoA approved these changes

@agrski agrski agrski approved these changes

@ukclivecox ukclivecox Awaiting requested review from ukclivecox

Assignees

@jesse-c jesse-c

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jesse-c @KengoA @agrski