update argocd and jenkins in cd demo and script for minikube #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This includes changes to use the jenkins identity store straight away. This is needed as crumb doesn't seem to work with the default store. I think we could simplify further by configuring the jobs from the beginning with https://github.com/helm/charts/tree/master/stable/jenkins#providing-jobs-xml But we could do that as a subsequent step. For the future I'd like to consider whether there's a way to avoid using the xml or avoid end users needing to fully understand it, rather like Jenkins-X has |
ryandawsonuk
changed the title
agrski
pushed a commit
that referenced
this pull request
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #505
linked pr - SeldonIO/cicd-demo-model-source-files#5