Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add kubectl option to pipeline-tests script #5307

Merged
merged 5 commits into from Feb 12, 2024

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Feb 12, 2024

What this PR does / why we need it:

Adding the option to run pipeline-tests.sh with kubectl and therefore smoke testing the controller.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@sakoush sakoush requested a review from lc525 as a code owner February 12, 2024 11:29
@sakoush sakoush changed the title fix: Add kubectl option to pipeline-test script fix: Add kubectl option to pipeline-tests script Feb 12, 2024
samples/pipeline-tests.sh Outdated Show resolved Hide resolved
samples/pipeline-tests.sh Outdated Show resolved Hide resolved
samples/pipeline-tests.sh Outdated Show resolved Hide resolved
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just added some small suggestions and an idea of improving this further in the future.

@sakoush sakoush merged commit 99f424d into SeldonIO:v2 Feb 12, 2024
2 of 3 checks passed
@sakoush sakoush added the v2 label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants