Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): Enable ISO time format in the logs #5319

Merged
merged 1 commit into from Feb 14, 2024
Merged

fix(controller): Enable ISO time format in the logs #5319

merged 1 commit into from Feb 14, 2024

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Feb 14, 2024

What this PR does / why we need it:
Switch to ISO time formats in the logs for legibility.

Which issue(s) this PR fixes:

Fixes # INFRA-714 (internal)

Special notes for your reviewer:

@sakoush sakoush requested a review from lc525 as a code owner February 14, 2024 12:58
@sakoush
Copy link
Member Author

sakoush commented Feb 14, 2024 

│ 2024-02-14T12:56:51.835Z    INFO    Reconcile    Creating component    {"controller": "seldonruntime", "controllerGroup": "mlops.seldon.io", "controllerKind": "SeldonRuntime", "seldonRuntime": {"name":"seldo │
│ 2024-02-14T12:56:51.835Z    INFO    Reconcile    Creating reconciler    {"controller": "seldonruntime", "controllerGroup": "mlops.seldon.io", "controllerKind": "SeldonRuntime", "seldonRuntime": {"name":"seld │
│ 2024-02-14T12:56:51.835Z    INFO    Reconcile    Creating component    {"controller": "seldonruntime", "controllerGroup": "mlops.seldon.io", "controllerKind": "SeldonRuntime", "seldonRuntime": {"name":"seldo │

lc525
lc525 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sakoush sakoush merged commit 0c83f9a into SeldonIO:v2 Feb 14, 2024
3 of 4 checks passed
@sakoush sakoush added the v2 label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lc525 lc525 lc525 approved these changes

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sakoush @lc525