fix(dataflow): wait for kafka topic creation #5375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kafka topic creation happens asynchronously. This means that even when the return value from `createTopics(...)` indicates that the topic has been created successfuly, the topic can not be immediately subscribed to. Instead of verifying the status of the topic from the `createTopics` return value, here we're repeatedly calling `describeTopics` until all of the topics for the pipeline can be described successfully. This indicates that the topic has been fully created _at least_ on one broker, and can now be subscribed to.
sakoush
approved these changes
Feb 26, 2024
| topicCreateTimeoutMillis, | ||
| topicDescribeTimeoutMillis, | ||
| topicDescribeRetries, | ||
| topicDescribeRetryDelayMillis, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is identical to the reviewed (and approved) lc525#47 but rebased against current seldonio/v2 for merging
What this PR does / why we need it:
Kafka topic creation happens asynchronously. This means that even when the return value from
createTopics(...)indicates that the topic has been created successfuly, the topic can not be immediately subscribed to.Instead of verifying the status of the topic from the
createTopicsreturn value, here we're repeatedly callingdescribeTopicsuntil all of the topics for the pipeline can be described successfully. This indicates that the topic has been fully created at least on one broker, and can now be subscribed to.Which issue(s) this PR fixes:
Fixes dataflow component for #INFRA-663 (internal): Pipeline creation goes into ERROR state