fix(modelgateway): KafkaAdmin error when fetching OIDC token #5428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new model is added, modelgateway creates quite a few connections to the kafka cluster, in quick succession (producer, consumer, admin). When using Confluent Cloud Kafka with OAUTHBEARER/OIDC token auth, the KafkaAdmin client failed to fetch the OIDC token sometimes. In tests we were using MS Entra ID, unsure if there is some rate-limiting on fetching tokens. Because we're not using the admin and producer connections concurrently (admin mostly used to create topics on model add), here we're letting the kafka admin client reuse the producer connection (and the same token). **Fixed issues**: - INFRA-867: Modelgateway sometimes fails to fetch OIDC tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new model is added, modelgateway creates quite a few connections to the kafka cluster, in quick succession (producer, consumer, admin).
When using Confluent Cloud Kafka with OAUTHBEARER/OIDC token auth, the KafkaAdmin client failed to fetch the OIDC token sometimes. In tests we were using MS Entra ID, unsure if there is some rate-limiting on fetching tokens.
Because we're not using the admin and producer connections concurrently (admin mostly used to create topics on model add), here we're letting the kafka admin client reuse the producer connection (and the same token).
Fixed issues: