fix(scheduler): Introduce sendMsg timeout for grpc streams (scheduler -> controller)
#5434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakoush
changed the title
sendMsg timeout for grpc streams (scheduler -> controller)
|
looks like the fix is working as I got on scheduler |
lc525
reviewed
Mar 15, 2024
lc525
reviewed
Mar 15, 2024
sakoush
commented
Mar 15, 2024
| ) | ||
|
|
||
| func (s *SchedulerServer) SubscribeExperimentStatus(req *pb.ExperimentSubscriptionRequest, stream pb.Scheduler_SubscribeExperimentStatusServer) error { | ||
| logger := s.logger.WithField("func", "SubscribeExperimentStatus") | ||
| logger.Infof("Received subscribe request from %s", req.GetSubscriberName()) | ||
|
|
||
| err := s.sendCurrentExperimentStatuses(stream) |
There was a problem hiding this comment.
lets also send experiment updates at startup similar to models and pipelines. This is something that we missed doing from previous work.
lc525
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a timeout for sending events to the controller from the scheduler. These events are sent on server side (scheduler) grpc streams (4x for each scheduler) and we have noticed that in some cases (pending more investigations of the root cause),
sendMsgblocks indefinitely because of the lack of control flow. We double checked the controller and it is also waiting on receive so we are for now ruling out any issues with slow consumers.The default timeout we added is 30s for each send and in this case we break the context and therefore the controller will detect a stream disconnect, and reestablishing the connection with new a stream to unblock events.
Note that we reply events so there is no risk of losing message with this logic.
logic inspired from: grpc/grpc-go#1229
This PR also adds:
stress-testsbash script to create multiple models of the same type in parallel (currently only 2 model types supported)Fixes INFRA-686 (internal)