Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add pipelines in stress test #5437

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Mar 15, 2024

This change adds tfsimples and tfsimples-join as cases for the stress test script. This is just for quick testing and we should really try and use the k6 setup for this kind of testing in the future.

@sakoush sakoush requested a review from lc525 as a code owner March 15, 2024 15:58
@sakoush sakoush added the v2 label Mar 15, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so now the last parameter is either a model or a pipeline, and for pipelines we need to append _pipeline (for the available ones). correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I will document is a bit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 908ca49

Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for a quick test. Worth documenting that the last parameter is either a model or a pipeline (amongst the supported ones)

@sakoush sakoush merged commit 4facca5 into SeldonIO:v2 Mar 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants