fix(dataflow): CVEs related to com.microsoft.azure:adal4j #5458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
com.microsof.azure:adal4j is a deprecated library, and an _optional_ dependency of io.kubernetes:client-java. However, when building fat-jars, gradle and the "shadow" plugin fetches all transitive depdendencies, including optional ones (i.e ones which are not used). In this case, we don't use any of the code in adal4j via io.kubernetes.
sakoush
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com.microsof.azure:adal4j is a deprecated library, and an optional dependency of io.kubernetes:client-java.
However, when building fat-jars, gradle and the "shadow" plugin fetches all transitive depdendencies, including optional ones (i.e ones which are not used).
In this case, we don't use any of the code in adal4j via io.kubernetes.
UNTESTED with confluent cloud due to external issue.
This shouldn't make a difference; we are using MS Entra ID for OAUTHBEARER auth, and MS AD (Active Directory) was the previous name for that.
adal4j is a deprecated library handling interactions with MS AD.
However, we shouldn't need to use it via k8s. Rather, the kafka streams library will make the right HTTP calls to Entra ID to fetch a token.
So this should be unrelated, but it would be good to make sure. Marked as draft because of not being able to test with Confluent Cloud yet.