fix(dataflow): Do not skip events to remove old pipeline versions #5469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc525
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
This set of changes does indeed look a bit strange, but thanks to your PR description it became easy to follow the logic. Makes perfect sense to me.
However, we have to be careful not to create any infinite loops in the future, as it seems it would be quite easy to do (now, there are some events without a source coming from "chainer-server")
LGTM
KengoA
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
LGTM!
For context the line from #5080 where events from chainer-server are ignored:
https://github.com/agrski/seldon-core/blob/c09abdd3ea897b9100dd779a9f0ddf72b19a82c1/scheduler/pkg/kafka/dataflow/server.go#L383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5080 there is a change to skip events coming from
chainer-server, this essentially has stopped the flow of removing old version of pipelines during a rolling update. The reason being is that the logic that triggers the removal of old versions of the pipeline (here) is eventually coming from setting the status of the new version of the pipeline from an event sent from the chainer-server.This PR then makes the change to not set the source of the events for deleting old version and therefore they can be processed further by chainer
handlePipelineEvent.This seems not very intuitive but I am not sure if there is a better way at the minute without a big refactor.