fix(deps): Upgrade sigs.k8s.io/controller-runtime to 0.17.4 #5562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required as part of a package upgrade
sakoush
commented
May 3, 2024
| @@ -46,7 +45,7 @@ func TestAPIs(t *testing.T) { | |||
| RunSpecsWithDefaultAndCustomReporters( | |||
| t, | |||
| "Controller Suite", | |||
| []Reporter{printer.NewlineReporter{}}, | |||
There was a problem hiding this comment.
this library printer doesnt exist anymore in controller-runtime and I dont think it is required for testing.
There was a problem hiding this comment.
appreciate the comment, helpful to know why the change was needed!
sakoush
commented
May 3, 2024
| @@ -63,16 +66,16 @@ func main() { | |||
| logger := zap.New(zap.UseFlagOptions(&opts)) | |||
| ctrl.SetLogger(logger) | |||
|
|
|||
| watchNamespace := namespace | |||
| watchNamespaceConfig := map[string]cache.Config{namespace: {}} | |||
There was a problem hiding this comment.
description of the new api is here
lc525
reviewed
May 3, 2024
| @@ -213,7 +212,7 @@ func (r *SeldonRuntimeReconciler) updateStatus(seldonRuntime *mlopsv1alpha1.Seld | |||
| } | |||
|
|
|||
| // Find SeldonRuntimes that reference the changes SeldonConfig | |||
| func (r *SeldonRuntimeReconciler) mapSeldonRuntimesFromSeldonConfig(obj client.Object) []reconcile.Request { | |||
| func (r *SeldonRuntimeReconciler) mapSeldonRuntimesFromSeldonConfig(_ context.Context, obj client.Object) []reconcile.Request { | |||
| logger := log.FromContext(context.Background()).WithName("mapSeldonRuntimesFromSeldonConfig") | |||
There was a problem hiding this comment.
would it make sense to pass the (currently unnamed) Context function argument here?
There was a problem hiding this comment.
The caller doesnt have a Context though as far as I can tell, I will add a TODO in the code to look at it more deeply.
lc525
reviewed
May 3, 2024
| @@ -184,7 +183,7 @@ func (r *ServerReconciler) updateStatus(server *mlopsv1alpha1.Server) error { | |||
| } | |||
|
|
|||
| // Find Servers that need reconcilliation from a change to a given ServerConfig | |||
| func (r *ServerReconciler) mapServerFromServerConfig(obj client.Object) []reconcile.Request { | |||
| func (r *ServerReconciler) mapServerFromServerConfig(_ context.Context, obj client.Object) []reconcile.Request { | |||
| logger := log.FromContext(context.Background()).WithName("mapServerFromServerConfig") | |||
There was a problem hiding this comment.
I have added a TODO in the code as per the answer in the previous review comment.
lc525
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR upgrades
controller-runtimefromv0.11.2tov0.17.4(~2 years difference). Note that there is a newer version of this packagev0.18.1but it requires go1.22and we are currently at go1.21.It required changes as the api has moved since then:
ctrl.NewManagercontextparameter)Which issue(s) this PR fixes:
Fixes INFRA-680 (internal)
TODO: