-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SeldonMessage with jsonData #595
Conversation
@gsunner Thank you for the PR. I would like to know the details about the spec.
Especially, if I would like to express predictions as a list of dict, what data type should
|
@yu-iskw I will try to explain how you can achieve what you need. The input is a json object value to the "jsonData" field. Here is an example how you can achieve this.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing one prediction.proto to change in loadtester
git ls-tree -r master --name-only | grep prediction.proto
proto/prediction.proto
python/seldon_core/proto/prediction.proto
util/loadtester/scripts/proto/prediction.proto
@gsunner Thank you for the example. I completely understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a test, otherwise looks good. Will need to open a separate issue to update SeldonClient once this is merged.
fixes #434
Whats implemented
Whats not implemented