Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python SeldonClient to handle JSON payloads #607

Closed
jklaise opened this issue May 31, 2019 · 5 comments · Fixed by #1082
Closed

Update Python SeldonClient to handle JSON payloads #607

jklaise opened this issue May 31, 2019 · 5 comments · Fixed by #1082
Labels
Python
Projects
1.1
Milestone
1.1

Comments

@jklaise
Copy link
Member

jklaise commented May 31, 2019

As a result of #595 .
@jklaise jklaise added the Python label May 31, 2019
@ukclivecox
Copy link
Contributor

Fixed in 0.3.0

@jklaise
Copy link
Member Author

jklaise commented Jun 17, 2019

Reopening as this is still missing.

@jklaise jklaise reopened this Jun 17, 2019
@axsaucedo
Copy link
Contributor

This was now added on 0.3.1, @jklaise good to close?

@jklaise
Copy link
Member Author

jklaise commented Jul 23, 2019

@axsaucedo if you say so, although I don't see the relevant PR in the changelog.

@axsaucedo
Copy link
Contributor

@cliveseldon I caught up with @jklaise to understand better, and what he was referring to is actually the support for the json_data= in the seldon client - which is unfortunately not added yet (although it would be a small change)

@axsaucedo axsaucedo mentioned this issue Aug 15, 2019
Merged
@ukclivecox ukclivecox added this to the 1.0.x milestone Aug 23, 2019
@ukclivecox ukclivecox added this to To do in 1.0 via automation Aug 23, 2019
@ukclivecox ukclivecox modified the milestones: 1.0, 1.1 Nov 7, 2019
@ukclivecox ukclivecox added this to To do in 1.1 via automation Nov 7, 2019
@ukclivecox ukclivecox removed this from To do in 1.0 Nov 7, 2019
@axsaucedo axsaucedo mentioned this issue Nov 10, 2019
Merged
1.1 automation moved this from To do to Done Nov 15, 2019
agrski added a commit that referenced this issue Dec 2, 2022
@agrski
Add validation for empty pipeline steps (#607)
f5bd3f9 
* Add error type for pipelines without steps defined

* Add pipeline validation for empty steps in scheduler

* Fix typo referencing wrong data in error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Python
Projects
No open projects
1.1
  
Done
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Update Python SeldonClient to handle JSON payloads axsaucedo/seldon-core
3 participants
@axsaucedo @ukclivecox @jklaise