Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exception catching for grpc calls in engine #966

Merged
merged 1 commit into from Oct 22, 2019
Merged

Add exception catching for grpc calls in engine #966

merged 1 commit into from Oct 22, 2019

Conversation

ukclivecox
Copy link
Contributor

Fixes #907

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cliveseldon

If they are not already assigned, you can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox ukclivecox removed the request for review from axsaucedo October 18, 2019 08:51
@ukclivecox ukclivecox merged commit cdbf5f0 into SeldonIO:master Oct 22, 2019
@ukclivecox ukclivecox deleted the 907_java_exceptions branch February 14, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryandawsonuk ryandawsonuk Awaiting requested review from ryandawsonuk

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Engine not catching grpc exceptions cleanly
2 participants
@ukclivecox @seldondev