Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GPT2 Example #192

Merged
merged 12 commits into from
Sep 9, 2021
Merged

Adding GPT2 Example #192

merged 12 commits into from
Sep 9, 2021

Conversation

axsaucedo
Copy link
Contributor

Current PR adds a GPT2 Pipeline example

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axsaucedo axsaucedo changed the title WIP: Adding GPT2 Example Adding GPT2 Example Sep 7, 2021
@axsaucedo axsaucedo requested review from ukclivecox and adriangonz and removed request for ukclivecox September 7, 2021 20:50
@axsaucedo
Copy link
Contributor Author

Ready to review (cc @cliveseldon @adriangonz )

"source": [
"## Prerequisites\n",
"\n",
"TODO"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be updated?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a requirements.txt or add required to tempo-examples conda environment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tf2onnx is not mentioned anywhere as prereq

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new example looks great! Should we remove the outputs on the generated README.md though? I thought that the make -C docs/examples all target would take care of that, but it seems it doesn't.

docs/examples/logging-insights/README.md Show resolved Hide resolved
@ukclivecox ukclivecox merged commit edf8cfa into SeldonIO:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants