Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled components should not have helper text #153

Closed
20BBrown14 opened this issue Mar 25, 2021 · 1 comment · Fixed by #156
Closed

Disabled components should not have helper text #153

20BBrown14 opened this issue Mar 25, 2021 · 1 comment · Fixed by #156
Assignees
@20BBrown14
Labels
released

Comments

@20BBrown14
Copy link
Contributor

20BBrown14 commented Mar 25, 2021 •
edited
Loading

Affected components: All of them

Disabled components should not have helper text/icons that indicate validation state below them. Consumers should take care that disabled fields do not violate any validation logic. Having validation helper text/icons could be confusing a user as they're unable to interact with that field.

There's also cases where we'd like to use a disabled multiselect, for instance, to get the tooltip and string display logic without having to rewrite it for a readonly field. As it stands a disabled multiselect will include the helper text which in a field of other readonly fields, for instance, is distracting and bad UI.

This should be an easy change in most components. if the isDisabled prop is true we should not render the HelperText component.
@20BBrown14 20BBrown14 self-assigned this Mar 25, 2021
20BBrown14 added a commit that referenced this issue Mar 25, 2021
@20BBrown14
fix: 🐛 HelperText no longer shows on disabled components
52dd557 
The HelperText / icon was showing on disabled components. It's not
longer doing that.

✅ Closes: #153
@20BBrown14 20BBrown14 mentioned this issue Mar 25, 2021
Merged
SeanGroff pushed a commit that referenced this issue Mar 26, 2021
@semantic-release-bot
chore(release): 4.3.3 [skip ci]
c158b19 
### [4.3.3](v4.3.2...v4.3.3) (2021-03-26)

### Bug Fixes

* 🐛 HelperText no longer shows on disabled components ([52dd557](52dd557)), closes [#153](#153)
@SeanGroff
Copy link
Contributor

🎉 This issue has been resolved in version 4.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@20BBrown14 20BBrown14

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 HelperText no longer shows on disabled components SelectQuoteLabs/SQForm
2 participants
@SeanGroff @20BBrown14