Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade react-scripts to 3.4.3 to emit eslint warnings #304

Closed
20BBrown14 opened this issue Jun 16, 2021 · 1 comment
Closed

Downgrade react-scripts to 3.4.3 to emit eslint warnings #304

20BBrown14 opened this issue Jun 16, 2021 · 1 comment

Comments

@20BBrown14
Copy link
Contributor

Currently in SQForm if there is an eslint warning (no-unused-vars, for instance) the whole compilation and build comes to a grinding halt. This is really annoying while developing. There is an issue with react-scripts 4.x.x that causes this. Downgrading to react-scripts 3.4.3 fixes the issue.

This shouldn't affect our code quality because when we run npm run commit eslint is still run and the commit fails if there are eslint warnings.
20BBrown14 added a commit that referenced this issue Jun 16, 2021
@20BBrown14
feat: 🎸 Add SQFormMultiValue component
1eb1531 
Add new component, SQFormMultiValue

✅ Closes: #303 & #304
20BBrown14 added a commit that referenced this issue Jun 16, 2021
@20BBrown14
feat: 🎸 Add SQFormMultiValue component
bc97b31 
Add new component, SQFormMultiValue

✅ Closes: #303 & #304
20BBrown14 added a commit that referenced this issue Jun 16, 2021
@20BBrown14
feat: 🎸 Add SQFormMultiValue component
50583c9 
Add new component, SQFormMultiValue

✅ Closes: #303 & #304
@20BBrown14 20BBrown14 mentioned this issue Jun 16, 2021
Merged
@20BBrown14 20BBrown14 linked a pull request Jun 16, 2021 that will close this issue
feat: 🎸 Add SQFormMultiValue component #306
Merged
@20BBrown14 20BBrown14 removed a link to a pull request Jun 17, 2021
feat: 🎸 Add SQFormMultiValue component #306
Merged
SeanGroff pushed a commit that referenced this issue Jun 17, 2021
@semantic-release-bot
chore(release): 4.8.0 [skip ci]
b575d9c 
## [4.8.0](v4.7.0...v4.8.0) (2021-06-17)

### Features

* 🎸 Add SQFormMultiValue component ([50583c9](50583c9)), closes [#303](#303) [#304](#304)
@laurelbean
Copy link
Contributor

Looks like this might be resolved. Open a new issue if this is still occurring.

@laurelbean laurelbean closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@laurelbean @20BBrown14