Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQFormTextField and SQFormTextArea have optional type Prop #45

Closed
20BBrown14 opened this issue Dec 30, 2020 · 1 comment · Fixed by #49
Closed

SQFormTextField and SQFormTextArea have optional type Prop #45

20BBrown14 opened this issue Dec 30, 2020 · 1 comment · Fixed by #49
Assignees
@20BBrown14
Labels
released

Comments

@20BBrown14
Copy link
Contributor

Curious on what people's thoughts are on having a type prop for SQFormTextField and SQFormTextArea so the consumer can define their own type on the MUI TextField.

Valid html types: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#Form_%3Cinput%3E_types

I'm thinking that mainly this would be good so we can provide a number type and get some of the HTML5 validation stuff. We could limit it to certain types if we wanted and of course we could default to Text.
20BBrown14 added a commit that referenced this issue Jan 4, 2021
@20BBrown14
feat: 🎸 Allow text fields HTML5 types
459469d 
Allow a HTML5 types to be supplied to SQForm text fields

✅ Closes: #45
20BBrown14 added a commit that referenced this issue Jan 4, 2021
@20BBrown14
feat: 🎸 Allow text fields HTML5 types
aa0617f 
Allow a HTML5 types to be supplied to SQForm text fields

✅ Closes: #45
@20BBrown14 20BBrown14 mentioned this issue Jan 4, 2021
Merged
@20BBrown14 20BBrown14 self-assigned this Jan 4, 2021
20BBrown14 added a commit that referenced this issue Jan 4, 2021
@20BBrown14
feat: 🎸 Allow text fields HTML5 types
ce44960 
Allow a HTML5 types to be supplied to SQForm text fields

✅ Closes: #45
github-actions bot pushed a commit that referenced this issue Jan 4, 2021
@semantic-release-bot
chore(release): 2.2.0 [skip ci]
a62d125 
## [2.2.0](v2.1.0...v2.2.0) (2021-01-04)

### Features

* 🎸 Allow text fields HTML5 types ([ce44960](ce44960)), closes [#45](#45)
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@20BBrown14 20BBrown14

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 🎸 Allow text fields HTML5 types SelectQuoteLabs/SQForm
1 participant
@20BBrown14