comparing values in "xxxEval" steps

[davidlinse]

There seems to be an issues with storing/comparing/evaluating expected values in xxxEval steps.

Example(s):

{ "type": "verifyEval", "script": "return 7;", "value": 7 } 

Error-Message: 'Eval result "7" does not match "".'

or:

{ "type": "verifyEval", "script": "return true;", "value": true } 

Error-Message: 'Eval result "true" does not match "true".'

I've setup a branch to demo this issue with a proposal for a fix.
Maybe you want to have a look here ?

kindest regards
~david

[Zarkonnen]

Thanks, looking at that now. Eval result "true" does not match "true".' is a bit overly philosophical for what's meant to be a straightforward tool. :P

• David

On Mar 26, 2014, at 10:24 , David Linse notifications@github.com wrote:

There seems to be an issues with storing/comparing/evaluating expected values in xxxEval steps.

Example(s):

{ "type": "verifyEval", "script": "return 7;", "value": 7 }
Error-Message: 'Eval result "7" does not match "".'

or:

{ "type": "verifyEval", "script": "return true;", "value": true }
Error-Message: 'Eval result "true" does not match "true".'

I've setup a branch to demo this issue with a proposal for a fix.
Maybe you want to have a look here ?

kindest regards
~david

—
Reply to this email directly or view it on GitHub.

[Zarkonnen]

OK, I ended up fixing it a bit differently than you did in your branch, but I also included your test - thanks!

9aa3941

• David

On Mar 26, 2014, at 10:24 , David Linse notifications@github.com wrote:

There seems to be an issues with storing/comparing/evaluating expected values in xxxEval steps.

Example(s):

{ "type": "verifyEval", "script": "return 7;", "value": 7 }
Error-Message: 'Eval result "7" does not match "".'

or:

{ "type": "verifyEval", "script": "return true;", "value": true }
Error-Message: 'Eval result "true" does not match "true".'

I've setup a branch to demo this issue with a proposal for a fix.
Maybe you want to have a look here ?

kindest regards
~david

—
Reply to this email directly or view it on GitHub.

[davidlinse]

Looks good so far, thanks for fixing this.
~david

[davidlinse]

Any chance for this to land in SE-Interpreter versions as well ?
Would really like to see (especially) the node.js variant getting updated.. ;)

best ~david

/cc: @Zarkonnen

[Zarkonnen]

It is gefixed in se-interpreter HEAD and shortly in the next release: Zarkonnen/se-interpreter@9ee1e2c