throw JavascriptException like the other drivers do

SeleniumHQ · Oct 17, 2020 · 4c492e8 · 4c492e8
1 parent 665995f
commit 4c492e8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/main/java/org/openqa/selenium/htmlunit/HtmlUnitWebElement.java b/src/main/java/org/openqa/selenium/htmlunit/HtmlUnitWebElement.java
@@ -29,6 +29,7 @@
 import org.openqa.selenium.ElementNotInteractableException;
 import org.openqa.selenium.InvalidElementStateException;
 import org.openqa.selenium.InvalidSelectorException;
+import org.openqa.selenium.JavascriptException;
 import org.openqa.selenium.NoSuchElementException;
 import org.openqa.selenium.OutputType;
 import org.openqa.selenium.Point;
@@ -151,13 +152,13 @@ void submitImpl() {
       } else if (element instanceof HtmlInput) {
         HtmlForm form = ((HtmlElement) element).getEnclosingForm();
         if (form == null) {
-          throw new NoSuchElementException("Unable to find the containing form");
+          throw new JavascriptException("Unable to find the containing form");
         }
         submitForm(form);
       } else {
         HtmlUnitWebElement form = findParentForm();
         if (form == null) {
-          throw new NoSuchElementException("Unable to find the containing form");
+          throw new JavascriptException("Unable to find the containing form");
         }
         form.submitImpl();
       }

diff --git a/src/test/java/org/openqa/selenium/FormHandlingTest.java b/src/test/java/org/openqa/selenium/FormHandlingTest.java
@@ -97,7 +97,8 @@ public void testShouldNotBeAbleToSubmitAFormThatDoesNotExist() {
     driver.get(pages.formPage);
     WebElement element = driver.findElement(By.name("SearchableText"));
     Throwable t = catchThrowable(element::submit);
-    assertThat(t, instanceOf(NoSuchElementException.class));
+    // assertThat(t, instanceOf(NoSuchElementException.class));
+    assertThat(t, instanceOf(JavascriptException.class));
   }
 
   @Test