New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beta v2 #1801
Conversation
PR Description updated to latest commit (3e89d99)
|
PR Review
✨ Review tool usage guide:Overview:
With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
CI Failure Feedback(Checks updated until commit 3e89d99)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
With a configuration file, use the following template:
See the improve usage page for a more comprehensive guide on using this tool. |
User description
Oh man its getting so much better haha lets go
Type
enhancement, bug_fix
Description
Changes walkthrough
52 files
index.ts
Enhance Playback Window Management and Navigation
packages/selenium-ide/src/main/session/controllers/Windows/index.ts
WebDriverExecutor
andretry
imports.requestWindowForPlayback
andclaimPlaybackWindow
.getPlaybackWindowName
to return empty string if test notfound.
navigatePlaybackWindow
method to handle URL navigation within aplayback window.
registerPlaybackWindow
to associate a WebDriver windowhandle with an Electron BrowserWindow.
requestPlaybackWindow
method to open a new playback windowwithout a specific playback session.
recalculatePlaybackWindows
to handle dynamic resizing ofplayback windows.
SystemSettings.tsx
Refactor SystemSettings Component to Use Context
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Project/SystemSettings.tsx
useContext
for accessing configuration context.ProjectSettings.tsx
Refactor ProjectSettings Component for Simplified Context Access
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Project/ProjectSettings.tsx
SuiteSelector.tsx
Optimize SuiteSelector with useMemo and Update Toolbar
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Suites/SuiteSelector.tsx
useMemo
for finding the matching suite.EditorToolbar
withSuitesToolbar
for a more modular approach.index.ts
Cleanup Playback Controller and Use Updated WebDriverExecutor Import
packages/selenium-ide/src/main/session/controllers/Playback/index.ts
WebDriverExecutor
fromside-runtime/dist/webdriver
.registerPlaybackWindow
.output.
TestsDrawer.tsx
Refactor TestsDrawer to Utilize Context for State Management
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Tests/TestsDrawer.tsx
information.
renderer.tsx
Integrate SessionContextProviders in ProjectEditor Renderer
packages/selenium-ide/src/browser/windows/ProjectEditor/renderer.tsx
PanelGroup
withSessionContextProviders
to provide context toall child components.
TestSelector.tsx
Simplify TestSelector Component with Context Usage
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Tests/TestSelector.tsx
index.tsx
Refactor ProjectEditor Component to Use Context Instead of Props
packages/selenium-ide/src/browser/components/ProjectEditor/index.tsx
management.
index.tsx
Enhance PlaybackControls with Internal Tab Management
packages/selenium-ide/src/browser/components/PlaybackControls/index.tsx
for updates.
index.tsx
Optimize Logger Component for Better Performance and Simplicity
packages/selenium-ide/src/browser/components/Logger/index.tsx
strings.
innerHTML
totextContent
.SuitesDrawer.tsx
Refactor SuitesDrawer for Context-Based State Management
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Suites/SuitesDrawer.tsx
index.tsx
Add New Tab Functionality and Styling Enhancements to PlaybackTabBar
packages/selenium-ide/src/browser/components/PlaybackTabBar/index.tsx
requestPlaybackWindow
API.index.tsx
Utilize Context for Drawer Visibility in AppBar Component
packages/selenium-ide/src/browser/components/AppBar/index.tsx
index.tsx
Implement New Input Component with Enhanced Focus Management
packages/selenium-ide/src/browser/components/Input/index.tsx
Input
component with focus management and dynamicvalue updates.
index.tsx
Refactor PlaybackDimensionControls to Use Context
packages/selenium-ide/src/browser/components/PlaybackDimensionControls/index.tsx
Toolbar.tsx
Introduce SuitesToolbar Component for Enhanced Modularity
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Suites/Toolbar.tsx
SuitesToolbar
component for modular toolbar management insuites.
index.ts
Extend Windows Commands API with Navigation and Request Functions
packages/side-api/src/commands/windows/index.ts
navigatePlaybackWindow
andrequestPlaybackWindow
to the windowscommands API.
tab.tsx
Enhance PlaybackTab Component to Display Test Name
packages/selenium-ide/src/browser/components/PlaybackTabBar/tab.tsx
index.tsx
Refactor URLBar to Handle Dynamic URL Updates Based on Tab
packages/selenium-ide/src/browser/components/URLBar/index.tsx
Controls.tsx
Refactor Test Controls Component to Use Context for Playback Status
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Tests/Controls.tsx
PlayButton.tsx
Refactor PlayButton to Use Context for Playback Control
packages/selenium-ide/src/browser/components/Controls/PlayButton.tsx
test ID.
TestsTab.tsx
Utilize Context in TestsTab for Simplified State Management
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Tests/TestsTab.tsx
logic.
ProjectTab.tsx
Refactor ProjectTab to Use Context for Configuration Settings
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Project/ProjectTab.tsx
provider.tsx
Implement SessionContextProviders for Context Management
packages/selenium-ide/src/browser/contexts/provider.tsx
SessionContextProviders
to wrap child components withsession-based context.
ProjectDrawer.tsx
Refactor ProjectDrawer to Use Context for Configuration Settings
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Project/ProjectDrawer.tsx
group.
SettingTabs.tsx
Utilize Context in SettingTabs for Configuration Settings Group
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Project/SettingTabs.tsx
group.
index.tsx
Simplify Main Component Structure by Removing Session Prop
packages/selenium-ide/src/browser/components/Main/index.tsx
Controls.tsx
Refactor SuiteControls to Use Context for Playback Status
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Suites/Controls.tsx
index.tsx
Simplify Drawer Component Structure by Utilizing Context
packages/selenium-ide/src/browser/components/Drawer/index.tsx
context.
SuitesTab.tsx
Refactor SuitesTab to Use Context for Session State
packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Suites/SuitesTab.tsx
webdriver.ts
Optimize WebDriverExecutor Logging for Debug Mode
packages/side-api/src/webdriver.ts
WebDriverExecutor
for debug mode.PlayListButton.tsx
Simplify PlayListButton Component by Removing Unused Props
packages/selenium-ide/src/browser/components/Controls/PlayListButton.tsx
controller.ts
Adjust ProjectEditor Window Configuration for macOS
packages/selenium-ide/src/browser/windows/ProjectEditor/controller.ts
active-test.ts
Introduce Context for Active Test and Suite ID Management
packages/selenium-ide/src/browser/contexts/active-test.ts
index.ts
Adjust State Controller for Dynamic Playback Window Resizing
packages/selenium-ide/src/main/session/controllers/State/index.ts
set
method to triggerrecalculatePlaybackWindows
for dynamicresizing.
active-command.ts
Introduce Context for Active Command Management
packages/selenium-ide/src/browser/contexts/active-command.ts
config-settings-group.ts
Introduce Context for Configuration Settings Group Management
packages/selenium-ide/src/browser/contexts/config-settings-group.ts
playback-command-states.ts
Introduce Context for Playback Command States Management
packages/selenium-ide/src/browser/contexts/playback-command-states.ts
session.ts
Introduce Context for Session State Management
packages/selenium-ide/src/browser/contexts/session.ts
show-drawer.ts
Introduce Context for Drawer Visibility Management
packages/selenium-ide/src/browser/contexts/show-drawer.ts
playback-current-index.ts
Introduce Context for Playback Current Index Management
packages/selenium-ide/src/browser/contexts/playback-current-index.ts
suite-mode.ts
Introduce Context for Suite Mode Management
packages/selenium-ide/src/browser/contexts/suite-mode.ts
suites.ts
Introduce Context for Suites Management
packages/selenium-ide/src/browser/contexts/suites.ts
playback-test-results.ts
Introduce Context for Playback Test Results Management
packages/selenium-ide/src/browser/contexts/playback-test-results.ts
status.ts
Introduce Context for Playback Status Management
packages/selenium-ide/src/browser/contexts/status.ts
tests.ts
Introduce Context for Tests Management
packages/selenium-ide/src/browser/contexts/tests.ts
subscribeToSession.ts
Add Default Session Initialization for Context
packages/selenium-ide/src/browser/helpers/subscribeToSession.ts
defaultSession
for initializing context with default values.onPlaybackWindowChanged.ts
Extend OnPlaybackWindowChanged Type with Test and URL
packages/side-api/src/commands/windows/onPlaybackWindowChanged.ts
OnPlaybackWindowChanged
type to includetest
andurl
.navigatePlaybackWindow.ts
Introduce navigatePlaybackWindow Command Type
packages/side-api/src/commands/windows/navigatePlaybackWindow.ts
navigatePlaybackWindow
command type for URL navigation.requestPlaybackWindow.ts
Introduce requestPlaybackWindow Command Type
packages/side-api/src/commands/windows/requestPlaybackWindow.ts
requestPlaybackWindow
command type for opening new playbackwindows.
index.css
Add Styles for Window Drag Regions and Margins
packages/selenium-ide/src/browser/index.css
2 files
index.ts
Adjust ResizablePanels Controller for Platform-Specific Offsets
packages/selenium-ide/src/main/session/controllers/ResizablePanels/index.ts
recalculatePlaybackWindows
to account for platform-specificoffsets.
record-shortcuts.ts
Update Record Shortcut Command Name for Consistency
packages/selenium-ide/src/browser/windows/PlaybackWindow/preload/record-shortcuts.ts
waitForElementText
towaitForText
for consistency with commandnames.